Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impl IntoIterator for &'_ Witness #1354

Merged

Conversation

Kixunil
Copy link
Collaborator

@Kixunil Kixunil commented Oct 28, 2022

It is considered idiomatic for types that have iter() method to also implement IntoIterator for their references. Witness was missing this so it is added here.

It is considered idiomatic for types that have `iter()` method to also
implement `IntoIterator` for their references. `Witness` was missing
this so it is added here.
@Kixunil Kixunil added enhancement minor API Change This PR should get a minor version bump trivial Obvious, easy and quick to review (few lines or doc-only...) 1.0 Issues and PRs required or helping to stabilize the API labels Oct 28, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d2ed0fe

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d2ed0fe

@apoelstra apoelstra merged commit d8e94cf into rust-bitcoin:master Oct 28, 2022
@Kixunil Kixunil deleted the impl_into_iterator_for_ref_witness branch October 28, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Issues and PRs required or helping to stabilize the API enhancement minor API Change This PR should get a minor version bump trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants