Do clippy improvements #1367
Merged
Do clippy improvements #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy emits a bunch of warnings of form: warning: casting to the same type is unnecessary ... As suggested, remove the unnecessary casts.
Clippy emits: warning: deref which would be done by auto-deref As suggested, remove the unnecessary deref (`*`).
Clippy emits: warning: binary comparison to literal `Option::None` As suggested, use `find.is_none()` instead of comparison with `None`.
Clippy emits: warning: the borrowed expression implements the required traits As suggested, remove the unnecessary explicit borrow.
Kixunil
approved these changes
Nov 4, 2022
| @@ -284,7 +284,7 @@ impl Decodable for BlockTransactionsRequest { | |||
| // Since the number of indices ultimately represent transactions, | |||
| // we can limit the number of indices to the maximum number of | |||
| // transactions that would be allowed in a vector. | |||
| let byte_size = (nb_indexes as usize) | |||
| let byte_size = (nb_indexes) | |||
There was a problem hiding this comment.
Hmm, it didn't complain about useless parentheses?
There was a problem hiding this comment.
We should remove this later. Merging this PR now to get the CI rolling
There was a problem hiding this comment.
bah, I must be blind. Will fix, thanks.
Kixunil
added
code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy has been updated and new warnings are being triggered in our codebase. This PR does all warnings using nightly since they all looked like reasonable things to fix.
Needed for CI to pass in other open PRs.