Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Witness conversion trait implementations #1391

Merged
merged 1 commit into from Nov 17, 2022
Merged

Witness conversion trait implementations #1391

merged 1 commit into from Nov 17, 2022

Conversation

nlanson
Copy link
Contributor

@nlanson nlanson commented Nov 15, 2022

#1385

Implemented:

  • From<Vec<Vec<u8>>>
  • From<&[&[u8]]>
  • From<&[Vec<u8>]>
  • From<Vec<&[u8]>>

tcharding
tcharding approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f0e72db

@Kixunil
Copy link
Collaborator

Kixunil commented Nov 15, 2022

Did you confirm blanket impls are not allowed due to coherence?

@nlanson
Copy link
Contributor Author

nlanson commented Nov 16, 2022

Did you confirm blanket impls are not allowed due to coherence?

Yep, getting a conflicting impl in core so can't do the blanket implementation.

Kixunil
Kixunil approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f0e72db

I think that these conversions are unlikely to cause problems.

apoelstra
apoelstra approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f0e72db

@apoelstra apoelstra merged commit b4a9a7a into rust-bitcoin:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlanson @Kixunil @apoelstra @tcharding