Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the SHA512 documentation #1407

Merged
merged 1 commit into from Nov 22, 2022

Conversation

kcalvinalvin
Copy link
Contributor

@kcalvinalvin kcalvinalvin commented Nov 22, 2022

Saw the typo and since this typo also exists in crates.io, I thought it'd be good to quickly change it.

Though maybe this should be replaced altogether with the hash_type macro since every other hash function implementation is using that.

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 57165d3

@Kixunil Kixunil added documentation trivial Obvious, easy and quick to review (few lines or doc-only...) one ack PRs that have one ACK, so one more can progress them labels Nov 22, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 57165d3

@apoelstra apoelstra merged commit e16b9bd into rust-bitcoin:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants