Replace Vec::from_hex with hex!
#1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
added
the
code quality
Kixunil
force-pushed
the
use-hex-macro
branch
2 times, most recently
from
103f434
to
22ab8d7
Compare
sanket1729
previously approved these changes
Dec 4, 2022
There was a problem hiding this comment.
ACK 22ab8d7. Thanks for exporting the pub macro in tests. I have versions of this in many downstream repos.
|
@sanket1729 oh crap, that is a remnant of my failed experiment. It doesn't work the way I intended. I want to change it to Edit: I removed the reexport because it's broken anyway. |
Kixunil
force-pushed
the
use-hex-macro
branch
from
22ab8d7
to
f6bd3a4
Compare
tcharding
reviewed
Dec 4, 2022
Kixunil
force-pushed
the
use-hex-macro
branch
from
f6bd3a4
to
6faf391
Compare
Kixunil
force-pushed
the
use-hex-macro
branch
from
6faf391
to
f797947
Compare
tcharding
previously approved these changes
Dec 23, 2022
|
Needs rebase after #1387 |
This makes the code less noisy and is a preparation for changing it to `const`-based literal. Because of the preparation, places that used variables to store the hex string were changed to constants. There are still some instances of `Vec::from_hex` left - where they won't be changeable to `const` and where `hex!` is unavailable (integration tests). These may be dealt with later. See also rust-bitcoin#1189
Kixunil
force-pushed
the
use-hex-macro
branch
from
f797947
to
089a1e4
Compare
apoelstra
approved these changes
Dec 31, 2022
tcharding
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code less noisy and is a preparation for changing it to
const-based literal. Because of the preparation, places that used variables to store the hex string were changed to constants.There are still some instances of
Vec::from_hexleft - where they won't be changeable toconstand wherehex!is unavailable (integration tests). These may be dealt with later.See also #1189
Note that while the change appears big it's nearly entirely mechanical, so should be pretty easy to review. (But I don't feel it's
trivial.)