Fix wrong newtype APIs #1503
Merged
Fix wrong newtype APIs #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several API bugs: * Use `TryFrom` instead of `From` for fallible conversions * Move byte conversion methods from `impl_array_newtype` to `impl_bytes_newtype` * Add missing trait impls like `AsRef`, `Borrow`, their mutable versions and infallible conversions from arrays Closes rust-bitcoin#1336
Kixunil
added
bug
API break
Upasana33
reviewed
Dec 23, 2022
| @@ -149,7 +149,7 @@ impl PartiallySignedTransaction { | |||
| } | |||
| let derivation = DerivationPath::from(path); | |||
| // Keys, according to BIP-174, must be unique | |||
| if xpub_map.insert(xpub, (Fingerprint::from(&fingerprint[..]), derivation)).is_some() { | |||
| if xpub_map.insert(xpub, (Fingerprint::from(fingerprint), derivation)).is_some() { | |||
| return Err(encode::Error::ParseFailed("Repeated global xpub key")) | |||
There was a problem hiding this comment.
I think there are two missing tests that need to be checked
There was a problem hiding this comment.
Unrelated but which ones? Why do you think?
tcharding
approved these changes
Dec 23, 2022
apoelstra
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several API bugs:
TryFrominstead ofFromfor fallible conversionsimpl_array_newtypetoimpl_bytes_newtypeAsRef,Borrow, their mutable versions and infallible conversions from arraysCloses #1336
Notably this change is much less bad than even I expected and some places actually get cleaner than before.