Add more mutation testing to the pow module
#1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
12-29-pow-more-mutagen
branch
2 times, most recently
from
86cf1d3
to
0cea7ec
Compare
apoelstra
previously approved these changes
Dec 30, 2022
Fix a trivial grammatical mistake in code comment.
Plain integer does not require parenthesis, remove them.
Recently we introduced some mutation testing to the `pow` module but testing is never done - add more `mutate` attributes and add unit tests to ensure all mutants are killed. Of note, the `from_compact` and `to_compact_lossy` functions are not done, doing so results in a bunch of surviving mutants.
tcharding
force-pushed
the
12-29-pow-more-mutagen
branch
from
0cea7ec
to
308c727
Compare
|
Changes in force push:
|
Kixunil
approved these changes
Jan 13, 2023
apoelstra
approved these changes
Jan 15, 2023
elichai
reviewed
Jan 16, 2023
| fn u256_is_max_correct_positive() { | ||
| assert!(U256::MAX.is_max()); | ||
|
|
||
| let u = u128::max_value(); |
There was a problem hiding this comment.
FYI max_value() is deprecated and the MAX associated const should be used
There was a problem hiding this comment.
I believe MAX is not available in 1.41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more mutation testing to the
powmodule.The first two patches are preparatory clean up.
All functions/methods that are non-trivial are tested excluding:
to_compact_lossyfrom_compactfmt_decimalI think its ok to not test
fmt_decimal. The compact format ones require a bit of work to do but should be done at some stage.