Add standard constants to lock times #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
previously approved these changes
Jan 22, 2023
|
I don't think it's that complex but I don't mind being a bit more careful. This is unlikely to conflict anyway. |
|
Perhaps "hash many edge cases" is better than "notoriously complex" :) |
|
Looks good to me! Will ACK shortly. I agree it's not terribly complex but I do think it's reasonable to demand 3 ACKs for anything touching locktimes. cc @sanket1729 can you review this one? |
apoelstra
previously approved these changes
Jan 23, 2023
|
Needs rebase after #1575. |
Some of the lock time structs (`Height`, `Time` ect.) are missing standard constants for min, max ect. Add standard constants taking into consideration the various locktime corner cases. Add `max_value` and `min_value` to be consistent with Rust 1.41.1 (incl. `Sequence`). Fix: rust-bitcoin#1451
tcharding
dismissed stale reviews from sanket1729, apoelstra, and Kixunil
via
3c0598b
|
Rebase only, no other changes. |
apoelstra
approved these changes
Jan 25, 2023
Kixunil
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the lock time structs (
Height,Timeect.) are missing standard constants for min, max ect.Add standard constants taking into consideration the various locktime corner cases.
Add
max_valueandmin_valueto be consistent with Rust 1.41.1 (incl.Sequence).Fix: #1451
This PR is not complex in itself but locktimes are notoriously complex, please wait for 3 acks before merging - and ack'ing makes no guarantee that reviewer got all corner cases :)
There is no rush on this one, apoelstra, Kixunil, sanket1729 please just review when your brain is fresh.