Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary lifetime #1594

Merged
merged 1 commit into from Jan 30, 2023
Merged

Conversation

tcharding
Copy link
Member

Clippy emits:

warning: the following explicit lifetimes could be elided: 'a

As suggested, remove the unnecessary lifetime.

Clippy emits:

  warning: the following explicit lifetimes could be elided: 'a

As suggested, remove the unnecessary lifetime.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 53d4fe6

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'_ would be preferable but since this is blocking CI

ACK 53d4fe6

@tcharding
Copy link
Member Author

Just for my education, why favour '_ over removing the lifetime altogether? Is it because its explicit in other places so to be uniform?

@Kixunil
Copy link
Collaborator

Kixunil commented Jan 30, 2023

Yeah, borrow being visible in the code is helpful for understanding.

@apoelstra
Copy link
Member

Oops, sorry for letting this sit over the weekend. Will merge in a few minutes.

@apoelstra apoelstra merged commit 042b453 into rust-bitcoin:master Jan 30, 2023
@tcharding tcharding deleted the 01-27-clippy branch February 1, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants