Add '_ back into the BitStreamWriter #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we merged `commit 53d4fe6` to fix CI even though a better approach is to use `'_` because it assists reading the code (shows that the bit stream writer is not writing from a reference since its writing a `Copy` type `n`). Add back in the `'_` (I forget what its called).
|
Interesting, dtonlay musn't have updated the nightly toolchain yet since this is passing CI and not choking on the new |
|
|
apoelstra
approved these changes
Jan 30, 2023
Kixunil
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we merged
commit 53d4fe66b57c255086def2b5e47afaddee776b75to fix CI even though a better approach is to use'_because it assists reading the code (shows that the bit stream writer is not writing from a reference since its writing aCopytypen).Add back in the
'_(I forget what its called).