Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct devs to use nightly for embedded #1611

Merged
merged 1 commit into from Feb 7, 2023

Conversation

tcharding
Copy link
Member

The embedded test crate requires usage of the nightly toolchain, fix the docs to show this.

The embedded test crate requires usage of the nightly toolchain, fix the
docs to show this.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 55d17f2

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 55d17f2

@Kixunil
Copy link
Collaborator

Kixunil commented Feb 7, 2023

I wonder why nightly is needed though, I was under the impression this should work on stable at least.

@apoelstra apoelstra merged commit a58460b into rust-bitcoin:master Feb 7, 2023
@tcharding tcharding deleted the 02-03-embedded-nightly branch February 7, 2023 21:04
@tcharding
Copy link
Member Author

I didn't dig into it but this is the error

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/tobin/.cargo/registry/src/github.com-1ecc6299db9ec823/linked_list_allocator-0.10.4/src/lib.rs:1:41
  |
1 | #![cfg_attr(feature = "const_mut_refs", feature(const_mut_refs))]

@Kixunil
Copy link
Collaborator

Kixunil commented Feb 9, 2023

Ah, OK, I think we just should switch the dependency to something more sensible. IIUC that feature is quite unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants