Improve SighashCache API
#1625
Merged
Improve SighashCache API
#1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirement for a type dereferencing to `Transaction` prevented storing the cache in long-lived data without resorting to silly wrappers. Since `Borrow` is implemented both for `T` and for smart pointers it's a more flexible bound which this change implements. While this is technically breaking, all usual non-generic code will continue to work beause smart pointers generally have `Borrow` implemented.
It may be useful to access the transaction stored in `SighashCache` during signing or afterwards, especially when the transaction is stored without indirection (to enable long-lived storage). This change adds the appropriate accessors.
Kixunil
force-pushed
the
sighas-borrow
branch
from
e5078db
to
b3188bb
Compare
|
Needs #1610 |
tcharding
approved these changes
Feb 6, 2023
apoelstra
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the bound from
Deref<Target = Transaction>toBorrow<Transaction>(with respectivemutchanges) and adds accessors.Closes #1423 (PSBT stuff will be separate issue).