Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport Magic #1674

Merged
merged 1 commit into from Feb 27, 2023
Merged

Reexport Magic #1674

merged 1 commit into from Feb 27, 2023

Conversation

Kixunil
Copy link
Collaborator

@Kixunil Kixunil commented Feb 25, 2023

Writing network::Magic is more natural and less annoying than network::constants::Magic, so this change reexports it.

Closes #1667

Writing `network::Magic` is more natural and less annoying than
`network::constants::Magic`, so this change reexports it.

Closes rust-bitcoin#1667
@Kixunil Kixunil added enhancement trivial Obvious, easy and quick to review (few lines or doc-only...) labels Feb 25, 2023
@Kixunil Kixunil added this to the 0.30.0 milestone Feb 25, 2023
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 76c4c64

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 76c4c64

@apoelstra apoelstra merged commit 826a988 into rust-bitcoin:master Feb 27, 2023
@Kixunil Kixunil deleted the reexport-magic branch February 27, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reexport network::constants::Magic as network::Magic
3 participants