Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update internals CHANGELOG for release #1700

Merged
merged 3 commits into from Mar 14, 2023
Merged

update internals CHANGELOG for release #1700

merged 3 commits into from Mar 14, 2023

Conversation

apoelstra
Copy link
Member

.

Kixunil
Kixunil previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be02045

But do we even need changelog for internals? People aren't supposed to use it.

sanket1729
sanket1729 previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACk be02045

@apoelstra
Copy link
Member Author

But do we even need changelog for internals? People aren't supposed to use it.

Heh, good point. I think it's worthwhile to have it for our own sakes.

@apoelstra apoelstra dismissed stale reviews from sanket1729 and Kixunil via ca3b433 March 8, 2023 15:02
@apoelstra
Copy link
Member Author

Thanks for the ACKs guys, but I remembered as I was falling asleep that I forgot an important part of this PR -- I have to specify an explicit version in the Cargo.toml for bitcoin_hashes (and for bitcoin). Crates will not let me publish crates unless all their deps have explicit versions.

With this change, if we merge this then we can release hashes and internals from the same commit. I'm pretty sure.

@Kixunil
Copy link
Collaborator

Kixunil commented Mar 8, 2023

Yeah, IIRC sufficiently recent cargo allows this.

Kixunil
Kixunil previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca3b433

tcharding
tcharding reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca3b433

tcharding
tcharding previously approved these changes Mar 8, 2023
View reviewed changes
@apoelstra apoelstra marked this pull request as draft March 9, 2023 01:15
@apoelstra
Copy link
Member Author

Moving to draft since bitcoin-internals = "0.1.0" currently points to a malicious crate (currently, an unformatted version of our own, but that could change). See #1702.

@apoelstra apoelstra marked this pull request as ready for review March 13, 2023 16:03
@apoelstra apoelstra dismissed stale reviews from tcharding and Kixunil via 51f2f84 March 13, 2023 16:04
@apoelstra
Copy link
Member Author

Ok, renamed the internal crate to bitcoin-private since we have gotten no response from the guy who is squatting on bitcoin-internals. This PR should be good to go now.

Kixunil
Kixunil approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 51f2f84

internals/Cargo.toml
version = "0.1.0"
authors = ["Andrew Poelstra <apoelstra@wpsoftware.net>", "The Rust Bitcoin developers"]
license = "CC0-1.0"
repository = "https://github.com/rust-bitcoin/rust-bitcoin/"
documentation = "https://docs.rs/bitcoin-internals"
documentation = "https://docs.rs/bitcoin-private"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop this field entirely since it's the default anyway. Non-blocking.

tcharding
tcharding approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 51f2f84

@apoelstra apoelstra merged commit edcb6fb into master Mar 14, 2023
44 checks passed
@apoelstra apoelstra deleted the 2023-03--release-internals branch March 14, 2023 19:16
@apoelstra
Copy link
Member Author

Tagged and published bitcoin-private 0.1.0 and bitcoin_hashes 0.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@tcharding tcharding tcharding approved these changes

@sanket1729 sanket1729 sanket1729 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@apoelstra @Kixunil @sanket1729 @tcharding