Add a method to pow::Target for returning difficulty as an f64.
#1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
force-pushed
the
junderw/feature/target-difficulty-f64
branch
from
afc4ed3
to
93ac83a
Compare
This adds a conversion function to U256 to get an f64. We use the method shown in the following blog post. https://blog.m-ou.se/floats/ Target::MAX was converted to a f64 and set as a const that is verified in a unit test.
junderw
force-pushed
the
junderw/feature/target-difficulty-f64
branch
from
93ac83a
to
2158f88
Compare
|
I also noticed that |
|
The method used in Perhaps the call is just moving the It depends on how precise we need it to be (probably not very). |
|
@junderw I think we'd prefer precision over speed. But |
|
concept ACK. Will test and provide a real ACK soon. This is a neat approach. I hadn't considered just constructing an IEEE float directly like this. |
apoelstra
approved these changes
Mar 11, 2023
tcharding
approved these changes
Mar 14, 2023
Comment on lines
+236
to
+240
| /// Computes the popular "difficulty" measure for mining and returns a float value of f64. | ||
| /// | ||
| /// See [`difficulty`] for details. | ||
| /// | ||
| /// [`difficulty`]: Target::difficulty |
There was a problem hiding this comment.
nit but perhaps this is cleaner
/// Computes the popular "difficulty" measure for mining and returns a float value.
///
/// See [`Target::difficulty`] for details.
Kixunil
reviewed
Mar 14, 2023
| /// | ||
| /// [`difficulty`]: Target::difficulty | ||
| #[cfg_attr(all(test, mutate), mutate)] | ||
| pub fn difficulty_float(&self) -> f64 { TARGET_MAX_F64 / self.0.to_f64() } |
There was a problem hiding this comment.
Why not just change the type above?
| } | ||
|
|
||
| // Target::MAX as a float value. Calculated with U256::to_f64. | ||
| // This is validated in the unit tests as well. | ||
| const TARGET_MAX_F64: f64 = 2.695953529101131e67; |
There was a problem hiding this comment.
With a bit of additional work you could make to_f64 const fn so the magic constant wouldn't be needed. Maybe something for the future.
apoelstra
added a commit
that referenced
this pull request
Mar 18, 2023
4924148 Swap out `Work::log2` implementation for `U256::to_f64` (junderw) Pull request description: See: #1707 (comment) ACKs for top commit: Kixunil: ACK 4924148 apoelstra: ACK 4924148 Tree-SHA512: 39d5d10b65c9597df1103df1639c57d432f04798b4b2be990b59275b8bd1f08560f72db8cda9edafad202ed0e4bf16cef7798279841b2d713ed482855498d1fe
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Aug 31, 2023
Added to rust-bitcoin in rust-bitcoin/rust-bitcoin#1707.
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Aug 31, 2023
Made available in rust-bitcoin as of rust-bitcoin/rust-bitcoin#1707
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Aug 31, 2023
Made available in rust-bitcoin as of rust-bitcoin/rust-bitcoin#1707
shesek
added a commit
to Blockstream/electrs
that referenced
this pull request
Feb 10, 2024
Made available in rust-bitcoin as of rust-bitcoin/rust-bitcoin#1707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1703
This adds a conversion function to U256 to get an f64. We use the method shown in the following blog post.
https://blog.m-ou.se/floats/
Target::MAX was converted to a f64 and set as a const that is verified in a unit test.
The code is rather confusing, so I took a crack at explaining it in my comments as well. Please let me know if you want it cleaned up some more.