Add changelog entry for removal of FromHex
#1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the last round of releases (bitcoin 0.30, hashes 0.12) we removed the `FromHex` implementation from all types except vecs and arrays. We added `FromStr` impls for types that roundtrip with `Display`. We never added a changelog mention to either `bitcoin` or `hashes`, lets retroactively add an entry. Fix: rust-bitcoin#1747
Kixunil
approved these changes
May 19, 2023
Kixunil
added
documentation
trivial
tcharding
changed the title
FromHex
apoelstra
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last round of releases (bitcoin 0.30, hashes 0.12) we removed the
FromHeximplementation from all types except vecs and arrays. We addedFromStrimpls for types that roundtrip withDisplay.We never added a changelog mention to either
bitcoinorhashes, lets retroactively add an entry.Fix: #1747