Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psbt: Remove reexport of Prevouts #1872

Merged
merged 1 commit into from May 30, 2023

Conversation

tcharding
Copy link
Member

No idea why this re-export is here, the Prevouts type is not even used in the psbt module.

Remove the re-export of crate::sighash::Prevouts from pstb.

Fix: #1869

No idea why this re-export is here, the `Prevouts` type is not even used
in the `psbt` module.

Remove the re-export of `crate::sighash::Prevouts` from `pstb`.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ab4e6d6

@stevenroose
Copy link
Collaborator

ACK ab4e6d6

@stevenroose stevenroose merged commit 7bf0a10 into rust-bitcoin:master May 30, 2023
29 checks passed
@tcharding tcharding deleted the 05-24-rm-prevouts-export branch May 30, 2023 04:49
@apoelstra
Copy link
Member

Thanks for merging!

But @stevenroose in future can you make sure to merge with the bitcoin-maintainter-tools script? Aside from doing some sanity checks it makes sure that merge commits are signed and have a consistent format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpublish bitcoin::psbt::Pprevout
3 participants