This library is not solely dependent on Rust

[roy9495]

Fix: #1867

Docs claim this library is pure rust but it depends on libsecp256k1 (and optionally libbitcoinconsensus)
So, I changed the lib.rs file accordingly.

[apoelstra]

@roy9495 could you please update your local master to the current one on Github, and rebase this PR?

[tcharding]

Suggested change

	//! Except for its dependency on libsecp256k1(and optionally libbitcoinconsensus),
	//! Except for its dependency on libsecp256k1 (and optionally libbitcoinconsensus),

[roy9495]

@roy9495 could you please update your local master to the current one on Github, and rebase this PR?

Sure sir

[tcharding]

When you implement some fix from review can you make the change to the original commit. This way a PR does not contain commits that fix things in previous commits which makes review hard for the next reviewer. Thanks

[roy9495]

When you implement some fix from review can you make the change to the original commit. This way a PR does not contain commits that fix things in previous commits which makes review hard for the next reviewer. Thanks

Sir, can I squash the commits ?

[tcharding]

yes

[apoelstra]

@roy9495 yes, in this case you should just squash them, because the resulting single commit will be small and self-contained.

In general, you want to produce PRs that are a series of well-defined, well-motivated, self-contained commits which each compile and pass tests independently. For small changes, "squash everything into one commit" is a perfectly reasonable way to do this. For bigger ones this can take some practice and repeated invocation of git rebase -i, or even doing a git reset --soft master to go back to master with all your changes uncommitted and ready to be committed piece-meal. Or even just opening a new worktree (or fresh clone of the repo :P) and copy/pasting your changes in, committing as you go.

[Kixunil]

ACK 654f58d

[apoelstra]

ACK 654f58d

[roy9495]

Thank you