Use hex_lit::hex in benches #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the test `hex` macro is only available when the `test` compiler configuration option is set but we are using it in benches code, this works for use because `cargo bench` sets `test` for the current crate, however it breaks downstream crates. Fix: rust-bitcoin#1830
RCasatta
approved these changes
Jul 14, 2023
apoelstra
approved these changes
Jul 14, 2023
apoelstra
added a commit
that referenced
this pull request
Jul 17, 2023
99ded54 release 0.30.1 (Andrew Poelstra) b46b61a Use hex_lit::hex in benches (Tobin C. Harding) Pull request description: Needed to unstick rust-bitcoin/rust-miniscript#482 ACKs for top commit: tcharding: ACK 99ded54 sanket1729: utACK 99ded54 Tree-SHA512: d8eeb3203be8d5823a600f4e8066061f27a2eef576f7e979271bf435c4610ed1861b4416254eb52ed2306df250bebca35cec12e8ecaa3779ca12a7b8ddae3a3c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test
hexmacro is only available when thetestcompiler configuration option is set but we are using it in benches code, this works for use becausecargo benchsetstestfor the current crate, however it breaks downstream crates.Fix: #1830