Use newly released bech32 API #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
reviewed
Jul 21, 2023
apoelstra
reviewed
Jul 21, 2023
|
Overall looking pretty good :) |
Sweet huh, way better than earlier iterations. |
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
4321612
to
5c90027
Compare
|
5c90027 looking pretty good :) |
clarkmoody
reviewed
Jul 29, 2023
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
5c90027
to
bb23ef8
Compare
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
2 times, most recently
from
536d5ad
to
44d0782
Compare
apoelstra
reviewed
Aug 3, 2023
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
44d0782
to
d4e40b3
Compare
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
d4e40b3
to
d554060
Compare
tcharding
changed the title
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
d554060
to
92be241
Compare
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
92be241
to
e5a08ac
Compare
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
e5a08ac
to
34f8764
Compare
|
Rebase only, no other changes. |
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
34f8764
to
b85a0c9
Compare
|
Rebased to pick up recent pinning fix, no other changes. |
|
This is only the last patch, it is non-trivial and requires 2 maintainer acks to merge, though as mentioned elsewhere I think @clarkmoody's ack is worth something, especially since he is the original author and maintainer of |
apoelstra
added a commit
that referenced
this pull request
Sep 20, 2023
52f2332 Remove docs from witness version conversion functions (Tobin C. Harding) 47d6d78 Remove bip 173/350 test vectors (Tobin C. Harding) e0eaeaa Split ParseError out of Error (Tobin C. Harding) 0f536e8 Add new UnknownAddressTypeError for parsing address type (Tobin C. Harding) e2014cb Import error variants within dislay impl (Tobin C. Harding) 9d7791f Remove unnecessary self:: from error import (Tobin C. Harding) b2e485e Split the address error code out into a separate module (Tobin C. Harding) f34ca0c Move address.rs to address/mod.rs (Tobin C. Harding) Pull request description: In preparation for depending on the recently released version of `rust-bech32` do a bunch of preparatory fixes. 1. Improve `address` module error handling as we are doing else where at the moment 2. Remove bip 173 and 350 test vector tests, these are fully covered in bech32 3. Trim down the docs on `WitnessVersion` This PR is the first 8 patches of #1951 ACKs for top commit: sanket1729: ACK 52f2332 apoelstra: ACK 52f2332 Tree-SHA512: 67a4ea4020b4e5c9c8396e4195e06dbd1d11335788f9e52f60abbc0b399e37e5dacc9bb7fa4e88221670322fa3c3407ade059d5c709f96e2df97240f4524e08c
Use the new bech32 iterator API that Andrew and I wrote.
tcharding
force-pushed
the
07-21-use-bech32-segwit-iter
branch
from
b85a0c9
to
e4c7e01
Compare
|
Went back over this while rebasing because it was done a long time ago, noticed that there were some error variants that are now unused. No other changes. |
apoelstra
approved these changes
Sep 21, 2023
|
Nice!! I finally reviewed this in detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on the newly released version of
bech32, BOOM!