Add max standard tx weight constant to transaction #1968
Conversation
yancyribbens
force-pushed
the
feature/add-max-transaction-weight
branch
from
66c0cf1
to
cf172a0
Compare
bitcoin/src/blockdata/transaction.rs
Outdated
| /// The maximum weight for transactions we're willing to relay/mine. | ||
| pub const MAX_STANDARD_WEIGHT: Weight = Weight::from_wu(400_000); |
There was a problem hiding this comment.
Can we have a link to the line of code in Core in the docs here please so devs can quickly jump to it in future. Also the docs shouldn't be the same as Core's because rust-bitcoin is not Core, "we" don't relay or mine.
There was a problem hiding this comment.
As these rules are subject to change, ideally we want also want to say "as of bitcoin core 25.0" or something similar.
There was a problem hiding this comment.
Can we have a link to the line of code in Core in the docs here please so devs can quickly jump to it in future.
Sure no problem. I try to find the explanation using git blame but pasting the link directly in the code works too.
Also the docs shouldn't be the same as Core's because rust-bitcoin is not Core, "we" don't relay or mine.
As these rules are subject to change, ideally we want also want to say "as of bitcoin core 25.0" or something similar.
Updated.
yancyribbens
force-pushed
the
feature/add-max-transaction-weight
branch
from
cf172a0
to
2e3006a
Compare
Add a constant for the max transaction weight. Similar to max block weight. This value is pulled from core here