upgrade byteorder to 1.2 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does one review an dependency upgrade? Since we aren't pinning dependencies (that should be done in applications) there is no sense in actually reviewing the dependency. As long as our tests still work it's ok I guess? |
|
I do not know any other practically feasible criteria. In this case I need a feature of byteorder 1.2 (48bit integers) in Hammersbald, that is then used together with this library in bitcoin-spv. If this project would not move then it would force downstream projects to include several versions of the same lib. Best is not to have dependencies, but that is in many cases even more uneconomical. |
sgeisler
approved these changes
Dec 7, 2018
Davidson-Souza
pushed a commit
to Davidson-Souza/rust-bitcoin
that referenced
this pull request
Jul 12, 2023
…bols Fix typos in the external-symbols feature(bug)
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
lift failure bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.