Fix witness display bug #1999
Merged
Fix witness display bug #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the witness has zero elements or any of the individual witnesses is empty we panic. Panic is caused by subtracting 1 from a zero length. Check the length is non-zero before subtracting 1, print `[]` if empty.
We recently fixed a bug that causes a panic if a `Witness` contains an empty instruction. Add a unit test to verify it.
tcharding
force-pushed
the
08-16-witness-display-bug
branch
from
e3624b8
to
84614d9
Compare
|
Looks good! I guess there are technically two bugs, since there are two |
apoelstra
approved these changes
Aug 17, 2023
|
The |
RCasatta
approved these changes
Aug 28, 2023
Comment on lines
+71
to
+72
| if instructions.len() > 0 { | ||
| let last_instruction = instructions.len() - 1; |
There was a problem hiding this comment.
I think
match instructions.len().checked_sub(1) {
Some(last_instruction) => ...
None => ..
}
would be more refactor-solid and better convey the underflow risk
There was a problem hiding this comment.
Good suggestion, I'll do up another PR and let this one merge. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduce a custom
Debugimplementation for theWitnesswe introduced a bug that causes code to panic if the witness contains an empty instruction.The bug can be verified by putting patch 2 first or by running
cargo run --example sighashon master.