Introduce a basic justfile #2018
Conversation
|
Props to @dpc for the idea. |
|
LGTM. I think that |
justfile
Outdated
|
|
||
| # Run the formatter | ||
| format: | ||
| cargo +nightly fmt --all |
There was a problem hiding this comment.
Is it from Fedimint or do you actually expect people to run nightly formatter?
There was a problem hiding this comment.
@dpc we have to run the nightly formatter because the stable one butchers the codebase.
There was a problem hiding this comment.
Oh, OK. In Fedimint the nix dev shell sets up toolchain with stable compiler, but nightly rustfmt. But motivation was mostly some sweet unstable formatting options.
There was a problem hiding this comment.
Yep, same here. Pretty nice that Nix can do this automatically.
There was a problem hiding this comment.
Can achieve the same thing in guix @stevenroose?
There was a problem hiding this comment.
@tcharding it's doubtful because "nightly" is not a well-defined thing. When you use nightly compilers in Nix then you'll get different results on different invocatons, something that Nix allows because it's "pragmatic" while Guix does not because it takes reproducibility seriously.
There was a problem hiding this comment.
cough, cough
I will have you know that Nix takes reproducibility seriously, and there's nothing "ill-defined" about nightly.
In Fedimint rustfmt comes from nightly toolchain via fenix project input that is locked in flake.lock which includes checking its cryptographic checksum . When we decide it's time to update toolchains, we nix flake lock --update-input fenix and check-in newly pinned versions.
Fedimint artifacts produced via Nix are byte-reproducible, which we did absolutely nothing in particular to achieve.
You can verify it by going to some master branch build, taking the git commit (here: 87d68d8356c1d56c27c91de4fc70ee0952b07b13) running:
nix build 'github:fedimint/fedimint?rev=87d68d8356c1d56c27c91de4fc70ee0952b07b13#fedimint-pkgs' && sha256sum result/bin/*
waiting approximately forever, and then comparing the checksums with ones printed by the CI:
But yes, AFAICT Nix is more pragmatic. We can run Steam, systemd and use configuration language with the usual number of parenthesis.
There was a problem hiding this comment.
utACK 9f92480. Don't know much of just and I don't plan to use this, but if people find this handy we should go ahead and merge this.
|
Updated format command to use |
It looks like a Makefile where for example |
|
Added a brief mention to the README. |
Introduce usage of `just` by adding a basic `justfile`.
Introduce usage of
justby adding a basicjustfile.If this goes in we can add various script invocations to it plus other useful things that often get red CI runs (eg, checking no-std).