Fix clippy warnings #2029
Merged
Fix clippy warnings #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy emits: error: incorrect implementation of `clone` on a `Copy` type As suggested use `*self` instead of each individual field.
Clippy emits a bunch of warnings of form: warning: useless use of `vec!` As suggested, remove the vec and just use an array.
|
All PRs will need this to get past CI, please review/ack/merge @apoelstra (and @sanket1729). Thanks. |
apoelstra
approved these changes
Aug 25, 2023
|
Because these are tiny changes with no functional consequence, and CI is broken I'm just going to fast-track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version
clippy 0.1.72 (5680fa1 2023-08-23)just came out and we get a two new warnings. Fix them up.