Use network when calculating difficulty #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy a sentence from the `pow::Target::difficulty` function onto the `block:Header::difficulty` function.
The difficulty is a ratio of the max and current targets, since the max is network specific the difficulty calculation is also network specific. We already have network specific maximum target constants, use them when calculating the difficulty.
tcharding
force-pushed
the
11-03-difficulty-add-network
branch
from
53f62c0
to
12d615d
Compare
|
Done as part of #2121 |
Kixunil
approved these changes
Nov 3, 2023
| Network::Testnet => Target::MAX_ATTAINABLE_TESTNET, | ||
| Network::Signet => Target::MAX_ATTAINABLE_SIGNET, | ||
| Network::Regtest => Target::MAX_ATTAINABLE_REGTEST, | ||
| }; |
There was a problem hiding this comment.
Feels like this should be in consensus params.
There was a problem hiding this comment.
These are in Params::pow_limit, I thought it better to take a Network parameter not a Params parameter though because its more specific. Or am I missing something?
There was a problem hiding this comment.
We could have this?
pub fn difficulty(&self, params: &Params) -> u128 {
let max = params.pow_limit;
let d = max.0 / self.0;
d.saturating_to_u128()
}There was a problem hiding this comment.
I do think Network makes sense but I was thinking Params::new(network).pow_limit.
There was a problem hiding this comment.
Once we have Network: AsRef<Params>/Network: AsParams we should just take generic.
yancyribbens
reviewed
Nov 3, 2023
apoelstra
approved these changes
Nov 6, 2023
tcharding
added a commit
to tcharding/rust-psbt
that referenced
this pull request
Nov 10, 2023
Import code from https://github.com/rust-bitcoin/rust-bitcoin` comit: `966b190f238408e24efd768ffa2bcdb6046e0cea Merge rust-bitcoin/rust-bitcoin#2168: Use network when calculating difficulty` Also grab required code from `bitcoin/src/serde_utils.rs` and `internals/src/error.rs`. Make changes to get things building: - Use the most terse public bitcoin API (ie, don't reach down into modules when importing if there is a re-export at crate level) - Fix paths to use correct `crate::` vs `bitcoin::` - Import `bitcoin::consensus::encode` as `consensus` and add TODO comments about it.
tcharding
added a commit
to tcharding/rust-psbt
that referenced
this pull request
Nov 10, 2023
Import code from https://github.com/rust-bitcoin/rust-bitcoin` comit: `966b190f238408e24efd768ffa2bcdb6046e0cea Merge rust-bitcoin/rust-bitcoin#2168: Use network when calculating difficulty` Also grab required code from `bitcoin/src/serde_utils.rs` and `internals/src/error.rs`. Make changes to get things building: - Use the most terse public bitcoin API (ie, don't reach down into modules when importing if there is a re-export at crate level) - Fix paths to use correct `crate::` vs `bitcoin::` - Import `bitcoin::consensus::encode` as `consensus` and add TODO comments about it.
tcharding
added a commit
to tcharding/rust-psbt
that referenced
this pull request
Nov 12, 2023
Import code from https://github.com/rust-bitcoin/rust-bitcoin` comit: `966b190f238408e24efd768ffa2bcdb6046e0cea Merge rust-bitcoin/rust-bitcoin#2168: Use network when calculating difficulty` Also grab required code from `bitcoin/src/serde_utils.rs` and `internals/src/error.rs`. Make changes to get things building: - Use the most terse public bitcoin API (ie, don't reach down into modules when importing if there is a re-export at crate level) - Fix paths to use correct `crate::` vs `bitcoin::` - Import `bitcoin::consensus::encode` as `consensus` and add TODO comments about it.
lucky-whistle-dev
added a commit
to lucky-whistle-dev/rust-bsbt
that referenced
this pull request
Apr 1, 2024
Import code from https://github.com/rust-bitcoin/rust-bitcoin` comit: `966b190f238408e24efd768ffa2bcdb6046e0cea Merge rust-bitcoin/rust-bitcoin#2168: Use network when calculating difficulty` Also grab required code from `bitcoin/src/serde_utils.rs` and `internals/src/error.rs`. Make changes to get things building: - Use the most terse public bitcoin API (ie, don't reach down into modules when importing if there is a re-export at crate level) - Fix paths to use correct `crate::` vs `bitcoin::` - Import `bitcoin::consensus::encode` as `consensus` and add TODO comments about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difficulty is a ratio of the max and current targets, since the max is network specific the difficulty calculation is also network specific.
We already have network specific maximum target constants, use them when calculating the difficulty.
Patch 1 is a trival docs improvement to
block::Header::difficulty.