add conversions from TXIDs to merkle nodes #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
approved these changes
Nov 27, 2023
|
|
||
| impl From<Wtxid> for WitnessMerkleNode { | ||
| fn from(wtxid: Wtxid) -> Self { | ||
| Self::from(wtxid.0) |
There was a problem hiding this comment.
So this is not strictly wrong but since I think we should remove From<sha256d::Hash> this would then need to become Self(wtxid.0) (same above). Feel free to change but can go in either way.
There was a problem hiding this comment.
I think it doesn't hurt to keep From<sha256d::Hash> for *MerkleNode; after all that's what merkle nodes fundamentally are (hashes)
There was a problem hiding this comment.
@condution true, but the viewpoint we're moving toward is that MerkleNodes are a different kind of hash than sha256d::Hashes, even though they're computed with the same algorithm.
apoelstra
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2220.
Also adds the equivalent conversion trait from
Wtxid->WitnessMerkleNode.