Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary private extern crate #2283

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

tcharding
Copy link
Member

In #2278 I mistakenly left in the use extern crate after removing the pub from it - while not incorrect it is unnecessary.

In rust-bitcoin#2278 I mistakenly left in the `use extern crate` after removing the
`pub` from it - while not incorrect it is unnecessary.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0d9c7ad

@apoelstra
Copy link
Member

This qualifies under the "refactor" one-ACK carve-out.

@apoelstra apoelstra merged commit e5272f3 into rust-bitcoin:master Dec 13, 2023
29 checks passed
@tcharding tcharding deleted the 12-14-remove-extern-crate branch December 14, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants