base58: Re-name crate to base58ck

[tcharding]

The current name base58check is taken, as is base58. Use base58ck instead.

Add a brief section to the readme about the crate naming.

[coveralls]

Pull Request Test Coverage Report for Build 8334199202

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.821%

---

Totals
Change from base Build 8318043190:	0.0%
Covered Lines:	19750
Relevant Lines:	23562

---

💛 - Coveralls

[tcharding]

I removed all mention of "appears unmaintained" just to be less inflammatory, we don't know they are not maintained and we get in enough fights with the rest of the Rust community as it is.

[tcharding]

You were reviewing while was force pushing to fix my mistakes @Kixunil, sorry about that.

[apoelstra]

ACK 5dc770d LGTM. I think it is fine to say "unmaintained" but understand the desire not to start fights

[Kixunil]

"appears unmaintained" just to be less inflammatory, we don't know they are not maintained and we get in enough fights with the rest of the Rust community as it is.

If anyone is offended by simply stating that their crate which is not 1.0 didn't update for years and didn't respond to messages appears unmaintained then better know that they're that kind of person. You can't please everyone and I would definitely not go out of my way to please those kinds of people.

Also provided reasonable people, there is not problem with updating it later.

[tcharding]

Fair points, will add it back it.

[apoelstra]

ACK 7d57564 though "where as" should be one word

[tcharding]

Will fix to use correct spelling of whereas.

[apoelstra]

ACK dffd566

[Kixunil]

Looks like the maintainer of base58 is willing to transfer ownership, so let's just wait if he does.

[tcharding]

I kind of think we should just use the new name because of how the current base58check crate depends on base58 and sha2. Our base58 crate is quite different.

[tcharding]

Its not like we are trying to sell our crate to the world, its mainly just so rust-bitcoin can use it. People who want it will find it.

[apoelstra]

I have the same feeling -- we should leave base58 and base58check as the existing pair.

But let's wait a bit to see what the base58 maintainer thinks.

[apoelstra]

In 76aa10b if you are going to add the word whereas it needs to be preceded by a comma, not a semicolon. Otherwise ACK.

[tcharding]

If only I spoke English as a first language, oh wait ... :(

Implemented as suggested.

[apoelstra]

ACK 6b09857

[tcharding]

All the github stuff about requesting review from @Kixunil was just from me getting rid of requested changes because they are all implemented, did not mean to imply we are waiting on him. @sanket1729 have you a minute to review this one please, its trivial.

[sanket1729]

ACK 6b09857

[apoelstra]

Gonna merge this. Note that we will not cut a release off this PR. At the very least we also need #2481.

[tcharding]

Yep, release tracking PR is up in draft state already #2595