hash_types: add unit tests for display of all hash types in the library #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be checked against the 0.29.x branch, and against the commit prior to rust-bitcoin#1659 (40c2467^) and you will see that it is consistent EXCEPT: * In rust-bitcoin 0.29.x we did not have multiple sighash types, only `Sighash`; we now have `LegacySighash`, `SegwitV0Sighash`, and `TapSighash`. * In rust-bitcoin#1565 we deliberately changed the display direction of the sighashes, to match BIP 143. Fixes rust-bitcoin#2495.
Pull Request Test Coverage Report for Build 8101066712Details
💛 - Coveralls |
tcharding
approved these changes
Feb 29, 2024
|
This an go in by way of the carve out, its been open and ack'd for more than 2 weeks. |
|
Sounds good. And you could argue that adding unit tests is "CI only". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be checked against the 0.29.x branch, and against the commit prior to #1659 (40c2467^) and you will see that it is consistent EXCEPT:
Sighash; we now haveLegacySighash,SegwitV0Sighash, andTapSighash.FromHex#1565 we deliberately changed the display direction of the sighashes, to match BIP 143.Fixes #2495.