Improve leaf errors #2530
Merged
Improve leaf errors #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-bitcoin
|
I'm guessing a better naming convention will fall out once I've done this a few more times. I"m was leaning towards making the names a bit longer than usual but @Kixunil suggested shortening one recently. Not totally sure either way. Shall we merge and iterate? |
Pull Request Test Coverage Report for Build 8242086240Details
💛 - Coveralls |
Kixunil
reviewed
Mar 7, 2024
|
|
||
| impl TryFromError { | ||
| /// Returns the invalid non-witness version integer. | ||
| pub fn invalid(&self) -> u8 { self.invalid } |
There was a problem hiding this comment.
Yeah, this is too confusing I think. I'd prefer provided_version or something along those lines.
Leaf error types should typically have private fields, provide accessor functions, and not use `non_exhaustive`.
Leaf error types should typically have private fields, provide accessor functions, and not use `non_exhaustive`.
tcharding
force-pushed
the
03-01-leaf-errors
branch
from
da98a84
to
f8de795
Compare
sanket1729
reviewed
Mar 12, 2024
apoelstra
approved these changes
Mar 12, 2024
Kixunil
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of recent discussion go over the codebase and look for some places that the leaf errors are wrong. Does not do the whole code base, excludes
p2pand a couple of other places.