Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SHA384 #2538

Merged
merged 1 commit into from Mar 13, 2024
Merged

Add support for SHA384 #2538

merged 1 commit into from Mar 13, 2024

Conversation

TheBlueMatt
Copy link
Member

Based on #2473 as we need support for 48-byte arrays <-> hex conversions.

Closes #2483

@github-actions github-actions bot added C-bitcoin PRs modifying the bitcoin crate C-hashes PRs modifying the hashes crate C-base58 labels Mar 5, 2024
@coveralls
Copy link

coveralls commented Mar 5, 2024 •
edited

Pull Request Test Coverage Report for Build 8250071679

Details

  • 107 of 110 (97.27%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 84.105%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hashes/src/sha384.rs 97 100 97.0%
Totals Coverage Status
Change from base Build 8248431014: 0.06%
Covered Lines: 19647
Relevant Lines: 23360
💛 - Coveralls

tcharding
tcharding previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b3a7c14

@tcharding
Copy link
Member

tcharding commented Mar 6, 2024 •
edited

If you were to review/ack #2473 @TheBlueMatt we could get it in, @Kixunil is MIA.

Kixunil
Kixunil reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit looks good.

@tcharding
Copy link
Member

Can now be rebased, #2473 is in.

@TheBlueMatt
Add support for SHA-384
4e3bb73 
This is another truncated variant of SHA-512, so there's not a lot
to add here, but its occasionally useful, though often in
non-Bitcoin contexts.
@TheBlueMatt
Copy link
Member Author

Rebased, sorry I didn't have a chance to help with #2473.

Kixunil
Kixunil approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4e3bb73

sanket1729
sanket1729 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4e3bb73

@apoelstra apoelstra merged commit fd1b364 into rust-bitcoin:master Mar 13, 2024
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

@tcharding tcharding tcharding left review comments

Assignees
No one assigned
Labels
C-base58 C-bitcoin PRs modifying the bitcoin crate C-hashes PRs modifying the hashes crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SHA384
6 participants
@TheBlueMatt @coveralls @tcharding @Kixunil @sanket1729 @apoelstra