Automated nightly rustfmt (2024-03-10)

[github-actions]

Automated nightly rustfmt changes by create-pull-request GitHub action

[tcharding]

ACK 0499c37

In future you'll just one-ack merge these won't you @apoelstra?

[apoelstra]

@tcharding yeah, in future I'll one-ACK merge. The issue right now is that CI doesn't get run (but after #2548 it should). So it's hard to this at all. I guess, when I test locally I'm using the latest rustc nightly (including now the docstests, and including clippy) so that's some good evidence that the latest nightly is ok.

But anyway, I'm going to leave this open and see if, in 10 hours when the script runs again, it does so with the alternate token that allows CI to run.

[apoelstra]

Locally I'm getting

error: item has both inner and outer attributes
    --> units/src/amount.rs:1587:1
     |
1587 | / #[cfg(feature = "serde")]
1588 | | pub mod serde {
1589 | |     // methods are implementation of a standardized serde-specific signature
1590 | |     #![allow(missing_docs)]
...    |
1605 | |     //! }
1606 | |     //! ```
     | |___________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style
     = note: `-D clippy::mixed-attributes-style` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::mixed_attributes_style)]`

error: item has both inner and outer attributes
    --> units/src/amount.rs:1795:5
     |
1795 | /     #[cfg(feature = "alloc")]
1796 | |     pub mod as_btc {
1797 | |         //! Serialize and deserialize [`Amount`](crate::Amount) as JSON numbers denominated in BTC.
1798 | |         //! Use with `#[serde(with = "amount::serde::as_btc")]`.
     | |________________________________________________________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style

which is an error I've never seen before and I believe was introduced with today's nightly.

So neither of you should have acked this :).

[apoelstra]

We can't even disable this lint rust-lang/rust-clippy#12436

[Kixunil]

We can't even disable this lint rust-lang/rust-clippy#12436

Good that we've just pinned it then. :)

[tcharding]

So neither of you should have acked this :).

ACK means good by me to merge assuming CI passes, right? I did not, and was not planning on starting to, do local testing before acking PRs - I only locally test my own PRs.

[tcharding]

Bots don't rebase.