Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ServiceFlags::P2P_V2 #2555

Merged
merged 1 commit into from Mar 9, 2024
Merged

Add ServiceFlags::P2P_V2 #2555

merged 1 commit into from Mar 9, 2024

Conversation

achow101
Copy link
Contributor

@achow101 achow101 commented Mar 8, 2024

No description provided.

@github-actions github-actions bot added the C-bitcoin PRs modifying the bitcoin crate label Mar 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8208484843

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 83.778%
Totals Coverage Status
Change from base Build 8205024373: 0.001%
Covered Lines: 19517
Relevant Lines: 23296
💛 - Coveralls

tcharding
tcharding approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5818e04

@tcharding
Copy link
Member

I have no knowledge about p2p v2 but the code looks correct to me.

@tcharding
Copy link
Member

Thanks @achow101!

sanket1729
sanket1729 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5818e04

Kixunil
Kixunil approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5818e04

bitcoin/src/p2p/mod.rs Show resolved Hide resolved
@apoelstra apoelstra merged commit e58975a into rust-bitcoin:master Mar 9, 2024
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra left review comments

@sanket1729 sanket1729 sanket1729 approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
C-bitcoin PRs modifying the bitcoin crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@achow101 @coveralls @tcharding @Kixunil @apoelstra @sanket1729