Return error when constructing pubkey from slice #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructing a pubkey using `PublicKey::from_slice` can fail for reasons other than just incorrect length - we should not be using `expect` but rather returning the error. A purist might argue that we are now returning a nested error type with an unreachable variant: `ParsePublicKeyError::Encoding(FromSliceError::InvalidLength)` Is this acceptable or do we want to further improve this?
|
Mad props to @Sh0g0-1758 for finding this bug literally days after I introduced it - amazing, that could easily have gotten through to the next release. |
Pull Request Test Coverage Report for Build 8256499696Details
💛 - Coveralls |
This was referenced Mar 12, 2024
|
Personally I think the unreachable variant is fine. It'd be really hard and annoying to restructure this code to avoid it. Plausibly upstream we should add a pair of |
apoelstra
approved these changes
Mar 13, 2024
|
Andrew, kick your merge bot for me bro, I can't reach it from here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced by me in #2473, and uncovered by #2563 - amazing that it was found so quickly!
Constructing a pubkey using
PublicKey::from_slicecan fail for reasons other than just incorrect length - we should not be usingexpectbut rather returning the error.A purist might argue that we are now returning a nested error type with an unreachable variant:
ParsePublicKeyError::Encoding(FromSliceError::InvalidLength)Is this acceptable or do we want to further improve this?