Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internals: Release tracking PR v0.3.0 #2632

Merged
merged 1 commit into from Apr 2, 2024
Merged

internals: Release tracking PR v0.3.0 #2632

merged 1 commit into from Apr 2, 2024

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Mar 25, 2024 •
edited

In preparation for release add a changelog and bump the version number.

Please note, the changelog is pretty terse.

@github-actions github-actions bot added C-bitcoin PRs modifying the bitcoin crate C-units PRs modifying the units crate C-internals PRs modifying the internals crate doc C-base58 labels Mar 25, 2024
@tcharding
Copy link
Member Author

This will get red CI because of the current clippy problem.

@coveralls
Copy link

coveralls commented Mar 25, 2024 •
edited

Pull Request Test Coverage Report for Build 8443857368

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.225%
Totals Coverage Status
Change from base Build 8427789763: 0.0%
Covered Lines: 19066
Relevant Lines: 22909
💛 - Coveralls

@tcharding tcharding added this to the 0.32.0 milestone Mar 25, 2024
@apoelstra
Copy link
Member

CI is red because of our duplicate dependency lint. It is not red because of clippy, which shouldn't ever have a "current problem" because its version is pinned.

@tcharding
Copy link
Member Author

tcharding commented Mar 26, 2024 •
edited

Oh, you are correct. I thought there was a clippy warning at the moment in multiple places even with the pinning but looks like I was imagining things. All my complaining about slow dev process and this one was all me :)

@github-actions github-actions bot added the test label Mar 26, 2024
@tcharding
Copy link
Member Author

OMG few amusing fails yesterday, the "clippy problem" I had in mind is in the future #2629, goodness me.

@apoelstra
Copy link
Member

In 33a0cd8

I'm not exactly sure how CI is passing, but you definitely spelled grepp with two ps which will not work :)

@tcharding
internals: Bump version to 0.3.0
af6dc1d 
In preparation for release add a changelog and bump the version number.
@tcharding
Copy link
Member Author

In 33a0cd8

I'm not exactly sure how CI is passing, but you definitely spelled grepp with two ps which will not work :)

Because we are still not using set -o pipefail - I can't remember why we did not do that last time @dpc told us to, was it an omission or something else. Otherwise I'll add it to all our scripts.

@tcharding
Copy link
Member Author

I remember now, that particular pipe doesn't work with pipefail set because the greps fail by design when there is no duplicate.

@tcharding tcharding changed the title internals: Bump version to 0.3.0 internals: Release tracking PR v0.3.0 Mar 27, 2024
sanket1729
sanket1729 reviewed Mar 27, 2024
View reviewed changes
Cargo-recent.lock
@@ -105,7 +111,7 @@ version = "0.13.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "1930a4dabfebb8d7d9992db18ebe3ae2876f0a305fab206fd168df931ede293b"
dependencies = [
"bitcoin-internals",
"bitcoin-internals 0.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to 0.2.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, until we release a new version of hashes we will have two versions of internals in play.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its when we release the new version of secp that the duplicate goes away (indirectly because of current secp depending on hashes v0.13.0 depending on internals v0.2.0).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss-spoke, when we depend on the newly released version of secp.

apoelstra
apoelstra approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK af6dc1d

@tcharding tcharding added the P-high High priority label Mar 27, 2024
sanket1729
sanket1729 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK af6dc1d

@apoelstra apoelstra merged commit 684b453 into rust-bitcoin:master Apr 2, 2024
187 checks passed
@tcharding
Copy link
Member Author

tcharding commented Apr 2, 2024 •
edited

Tag and publish please @apoelstra

@tcharding
Copy link
Member Author

Then soon as its up we can release base58ck (I think).

@apoelstra
Copy link
Member

Oops. Tagged and published.

@tcharding tcharding deleted the 03-26-release-internals branch April 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
C-base58 C-bitcoin PRs modifying the bitcoin crate C-internals PRs modifying the internals crate C-units PRs modifying the units crate doc P-high High priority test
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tcharding @coveralls @apoelstra @sanket1729