Allow m prefix in derivation paths #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently in rust-bitcoin#2451 we disallowed bip32 derivation paths with the leading 'm' variable. There is some confusion as to what exactly the bip specifies however Bitcoin Core RPC call `getaddressinfo` returns a derivation path with a leading "m/". This means we need to be able to parse it irrespective of what the bip says. Be more liberal in what we accept as a derivation path, including both with and without the leading 'm/'. Leave the full investigation of the bip to a later date. Change back some of the test strings as makes sense and include test strings to showcase the full current behaviour.
Pull Request Test Coverage Report for Build 8695039328Details
💛 - Coveralls |
|
Just confirming, you are ok to merge this with the red |
|
Yep. I was gonna wait for a second ACK, but I think since we have 2 ACKs on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a single patch that was created using
cargo cherry-pick 830c1e9c- i.e., it is a backport of #2677.Recently in #2451 we disallowed bip32 derivation paths with the leading 'm' variable.
There is some confusion as to what exactly the bip specifies however Bitcoin Core RPC call
getaddressinforeturns a derivation path with a leading "m/". This means we need to be able to parse it irrespective of what the bip says.Be more liberal in what we accept as a derivation path, including both with and without the leading 'm/'.
Leave the full investigation of the bip to a later date.
Change back some of the test strings as makes sense and include test strings to showcase the full current behaviour.