Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accidentally added file #312

Merged
merged 1 commit into from Aug 11, 2019
Merged

Remove accidentally added file #312

merged 1 commit into from Aug 11, 2019

Conversation

real-or-random
Copy link
Contributor

Overlooked in #310.

@codecov-io
Copy link

Codecov Report

Merging #312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          38       38           
  Lines        6812     6812           
=======================================
  Hits         5571     5571           
  Misses       1241     1241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d66874...95cfea4. Read the comment docs.

@apoelstra
Copy link
Member

Hah, wow, that is really hard to see in the github view of #310.

@tamasblummer tamasblummer self-requested a review August 11, 2019 10:03
@tamasblummer tamasblummer merged commit fb27216 into rust-bitcoin:master Aug 11, 2019
Davidson-Souza pushed a commit to Davidson-Souza/rust-bitcoin that referenced this pull request Jul 12, 2023
@apoelstra
Merge rust-bitcoin/rust-secp256k1#313: Serde implementation for KeyPa…
ada3f98 
…ir type

de77518 Serde serialization for KeyPair (Dr Maxim Orlovsky)

Pull request description:

  Serde implementation for `KeyPair` type (which hadn't it before).

  Based on rust-bitcoin#312 (includes all commits from that PR, will be rebased upon merge)

ACKs for top commit:
  apoelstra:
    ACK de77518

Tree-SHA512: 1e75c4fc772dcba5ce7edb30235a58550342cf986c6a77b4affd81defeba456c9655e28b081e0040c1f8440da3f7ad2224485d35222c1921099567b4d1533794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tamasblummer tamasblummer tamasblummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@real-or-random @codecov-io @apoelstra @tamasblummer