Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit in VersionMessage documentation #343

Merged
merged 1 commit into from Dec 5, 2019
Merged

Nit in VersionMessage documentation #343

merged 1 commit into from Dec 5, 2019

Conversation

stevenroose
Copy link
Collaborator

@stevenroose stevenroose commented Nov 19, 2019 •
edited

@codecov-io
Copy link

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files          38       38           
  Lines        7032     7032           
=======================================
  Hits         5743     5743           
  Misses       1289     1289
Impacted Files Coverage Δ
src/network/message_network.rs 25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700ed54...33ba7ea. Read the comment docs.

apoelstra
apoelstra approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

elichai
elichai approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. verified against the new() implementation we have.

@elichai elichai merged commit 0ae9910 into rust-bitcoin:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@elichai elichai elichai approved these changes

@tamasblummer tamasblummer Awaiting requested review from tamasblummer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stevenroose @codecov-io @apoelstra @elichai