Expose secp256k1 features #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By exposing this, we can use the 'rand' dependency of secp256k1 in a project that only depends on rust-bitcoin without having to add a separate dependency in order to activate the feature flag.
thomaseizinger
force-pushed
the
expose=secp256k1-features
branch
from
3718a09
to
7be4ac0
Compare
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 38 38
Lines 7032 7032
=======================================
Hits 5743 5743
Misses 1289 1289Continue to review full report at Codecov.
|
elichai
approved these changes
Nov 23, 2019
|
Eh I somehow recall that serde thing being there. Perhaps I didn't figure out I couldn't serialize because of this feature. I guess until Cargo let's us somehow enable sub-features from the toml file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two patches that expose feature flags from the underlying
secp256k1library.The primary benefit here is that we can activate the
randfeature from a crate that only depends onrust-bitcoinbut would like to make use of the feature-gatedrandfunctionality insecp256k1. The current workaround here is to add an additional dependency onsecp256k1that includes the feature flag. This works because cargo accumulates feature flags across the dependency tree.Unfortunately, this requires to activately keep those versions in sync. By giving access to the
randfeature flag ofsecp256k1through arandfeature flag inrust-bitcoin, this situation can be avoided.Additionally, I noticed that the
serdefeature insecp256k1is not included in theuse-serdefeature ofrust-bitcoin. The 2nd patch fixes this.