Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 350 #360

Merged
merged 2 commits into from Dec 10, 2019
Merged

Feature/issue 350 #360

merged 2 commits into from Dec 10, 2019

Conversation

kiminuo
Copy link
Contributor

@kiminuo kiminuo commented Dec 8, 2019

Tested on Windows, using:

git clone --single-branch --branch feature/issue-350 https://github.com/kiminuo/rust-bitcoin.git
Cloning into 'rust-bitcoin'...
remote: Enumerating objects: 69, done.
remote: Counting objects: 100% (69/69), done.
remote: Compressing objects: 100% (50/50), done.
remote: Total 5325 (delta 28), reused 31 (delta 13), pack-reused 5256
Receiving objects: 100% (5325/5325), 2.18 MiB | 2.41 MiB/s, done.
Resolving deltas: 100% (3412/3412), done.

@codecov-io
Copy link

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files          39       39           
  Lines        7850     7850           
=======================================
  Hits         6476     6476           
  Misses       1374     1374

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8547182...d8223bb. Read the comment docs.

@TheBlueMatt
Copy link
Member

travis-fuzz isnt whats used to generate the fuzz outputs, though it may be useful to have a contrib/rename-fuzz-files.sh file that can be installed as a git pre-commit hook.

@kiminuo
Copy link
Contributor Author

kiminuo commented Dec 8, 2019

@TheBlueMatt I know. The idea was that travis-fuzz.sh would reveal that newly added/modified fuzz inputs will cause trouble for Windows users.

I'm open to make changes.

Copy link
Member

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'm sorry, I didn't read close enough. Looks good.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants