bip157: Fix typo on getcfcheckpt command string #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can add tests if you show me how to get bytes vector samples for network messages |
5o50
changed the title
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 82.56% 81.91% -0.65%
==========================================
Files 39 39
Lines 8236 7179 -1057
==========================================
- Hits 6800 5881 -919
+ Misses 1436 1298 -138
Continue to review full report at Codecov.
|
elichai
approved these changes
Dec 22, 2019
elichai
approved these changes
Dec 22, 2019
Davidson-Souza
pushed a commit
to Davidson-Souza/rust-bitcoin
that referenced
this pull request
Jul 12, 2023
…ents 0e0fa06 Simplify `Display` impl of `SerializedSignature` (Martin Habovstiak) 5d51b9d Added `MAX_LEN` constant to `serialized_signature` (Martin Habovstiak) e642a52 Add `#[inline]` to methods of `SerializedSignatre` (Martin Habovstiak) e92540b `impl IntoIterator for SerializedSignature` (Martin Habovstiak) 7f2d3d2 Move `SerializedSignature` into its own module (Martin Habovstiak) 901d5ff `impl<'a> IntoIterator for &'a SerializedSignature` (Martin Habovstiak) 1d2a1c3 Deduplicate `self.data[..self.len]` expressions (Martin Habovstiak) Pull request description: This * Deduplicates slicing operations * Implements `IntoIterator` (owned and borrowed) * Reorganizes the code for better clarity * Adds `#[inline]`s * Checks length set by libsep256k1 Closes rust-bitcoin#367 Closes rust-bitcoin#368 Individual commits are hopefully easier to review. ACKs for top commit: apoelstra: ACK 0e0fa06 Tree-SHA512: bbc759af767c8b84bfd6720456efc1e86da501aa193641dae3c99847a3c882f7d4aa7e5cbec074fdd9c2595f1f65e5fbb4c80620539a6357927149e5c2fbc734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a small typo on BIP157
getcfcheckptmessage command serialization/deserialization.cf: https://github.com/bitcoin/bips/blob/master/bip-0157.mediawiki#getcfcheckpt