New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hygiene/single code style for all existing macros #403
Conversation
FYI, have figured out how the macro system works:
|
Is it worth it to have all this verbosity for macros we don't export? |
What I am sure is that
|
seems Travis needs reset |
I restarted the timed out test with cleared caches. |
I have rebased this onto master. Pls let me know if there any need in this. |
I'm for better macro hygiene, it will also ease our life when we will update to edition 2018. |
ack 257ca8e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
While being not really important, had to do hygiene of all internal macros (since many of which I re-use in other places) such they now follow the same standard/coding style for all namespace prefixes (i.e. starting with
::
followed by a fully-clarified name).Also added doc strings to some of the macros