Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modulo division operation for Uint128 & Uint256 types #435

Merged
merged 2 commits into from Jul 22, 2020
Merged

Modulo division operation for Uint128 & Uint256 types #435

merged 2 commits into from Jul 22, 2020

Conversation

dr-orlovsky
Copy link
Collaborator

No description provided.

stevenroose
stevenroose requested changes Jul 12, 2020
View reviewed changes
Copy link
Collaborator

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation LGTM, you have an indentation wrong though

src/util/uint.rs Outdated Show resolved Hide resolved
@TheBlueMatt
Copy link
Member

Can you add to the u128-comparison fuzz test?

@dr-orlovsky
Copy link
Collaborator Author

With the new push, fuzz test is added + indentation problem is fixed.

sgeisler
sgeisler approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elichai
elichai approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this, and in a follow up PR I can optimize it to remove the subtraction and the multiplication (sub_copy in the division actually contains the remainder already)

@stevenroose stevenroose merged commit 1d5b8da into rust-bitcoin:master Jul 22, 2020
@elichai elichai mentioned this pull request Jul 22, 2020
Merged
@dr-orlovsky dr-orlovsky mentioned this pull request Sep 3, 2020
Merged
@dr-orlovsky dr-orlovsky mentioned this pull request Sep 12, 2020
Closed
22 tasks
@dr-orlovsky dr-orlovsky mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@stevenroose stevenroose stevenroose approved these changes

@sgeisler sgeisler sgeisler approved these changes

@elichai elichai elichai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dr-orlovsky @TheBlueMatt @stevenroose @sgeisler @elichai