Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the util::contracthash module #451

Merged
merged 1 commit into from Sep 9, 2020

Conversation

stevenroose
Copy link
Collaborator

No description provided.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this module superseded by something? I never worked with it and it reads a bit like really primitive miniscript, that just allows to build scripts from templates. If there's not other functionality that's safe and useful it should be deprecated to eventually be removed.

@apoelstra
Copy link
Member

@sgeisler superceded by Miniscript. There is some key-tweaking logic in there that doesn't exist elsewhere but it's not hard to implement independently.

@apoelstra
Copy link
Member

...and I am planning to implement it in rust-miniscript, when we update our Liquid code to use this version of rust-bitcoin

@apoelstra apoelstra merged commit 5fd91ca into rust-bitcoin:master Sep 9, 2020
@elichai
Copy link
Member

elichai commented Sep 14, 2020

I chased a warning on deprecated empty test for half an hour until I've found that this was the culprit :(
https://pastebin.com/raw/SyJvV5p8

Can we please add a reason to ease finding the source? (ie #![deprecated = "superceded by Miniscript"])

@elichai
Copy link
Member

elichai commented Sep 14, 2020

I chased a warning on deprecated empty test for half an hour until I've found that this was the culprit :(
https://pastebin.com/raw/SyJvV5p8

Can we please add a reason to ease finding the source? (ie #![deprecated = "superceded by Miniscript"])

Saw this now: 05f3451 sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants