Re-export all types inside the network module #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
reviewed
Nov 23, 2020
src/network/mod.rs
Outdated
| pub use self::message::*; | ||
| pub use self::message_blockdata::*; | ||
| pub use self::message_network::*; | ||
| pub use self::message_filter::*; |
There was a problem hiding this comment.
Can you make an explicit list?
It will be long but using * makes the codebase ungreppable.
There was a problem hiding this comment.
I'm concerned about types being forgotten when explicit listing. How do you(/we) feel about making the submodules private so that all types have to be exported (otherwise cargo will shout unused).
stevenroose
force-pushed
the
export-network
branch
from
17c6366
to
3b8efcc
Compare
|
Ok so I redid this PR, now the internal modules are made private so this is a breaking change. I think the API is a lot more usable like this. |
stevenroose
added
the
API break
Also make the inner modules private so that all network-related types come in a single namespace in the API. This gives more ease-of-use and gives us more flexibility to organize the types as we like.
|
I suppose #525 supersedes this one. |
|
Closing in favor of #525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really quite confusing which network messages are in which submodules etc. I've been doing some work on rust-bitcoin-p2p over the weekend and this re-export would really simplify things a lot!