PSBT types are now constants #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
dpc
reviewed
Dec 5, 2020
apoelstra
reviewed
Dec 7, 2020
src/util/psbt/map/input.rs
Outdated
| /// Type: Finalized scriptWitness PSBT_IN_FINAL_SCRIPTWITNESS = 0x08 | ||
| const PSBT_IN_FINAL_SCRIPTWITNESS: u8 = 0x08; | ||
| /// Type: RIPEMD160 preimage | ||
| const PSBT_IN_RIPEMD160_PREIMAGES: u8 = 0x0a; |
There was a problem hiding this comment.
I think we should drop the _PREIMAGES suffix here to match the BIP.
There was a problem hiding this comment.
Correct, doing that
There was a problem hiding this comment.
Done with a separate commit to simplify the review (what's changed)
apoelstra
approved these changes
Dec 7, 2020
|
ACK 881f4d7 |
sgeisler
approved these changes
Dec 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not create any external API changes, but is useful for code readability, internal consistency & future work, preventing from typos-type mistakes etc.
Part of PSBT/BIP32 refactoring epic #473