New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release 0.26.2 #611
Fix release 0.26.2 #611
Conversation
Fixes rust-bitcoin#608. In rust-bitcoin#567 the Display impl for ChildNumber was consciously changed, assuming the semver break would not affect any correctly implemented downstream projects. We were wrong.
9211dcb
to
055d0fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this fixes rust-miniscript downstream.
ack 055d0fb
|
||
The previous release changed the behavior of `Display` for `ChildNumber`, assuming that any correct usage would not be | ||
affected. [Issue 608](https://github.com/rust-bitcoin/rust-bitcoin/issues/608) goes into the details of why this isn't | ||
the case and how we broke both `rust-miniscript` and BDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a trailing space here, but I'll let it go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack 055d0fb
We broke downstream with 0.26.1, I propose yankign it and releasing 0.26.2. This fixes #608 and closes #609 .