Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Error types (part 4) #625

Merged
merged 1 commit into from Sep 8, 2021
Merged

Improvements to Error types (part 4) #625

merged 1 commit into from Sep 8, 2021

Conversation

dr-orlovsky
Copy link
Collaborator

Removes controversial aspects from #560 (all io::Error-related changes) and leaves the rest

@dr-orlovsky dr-orlovsky added the API break This PR requires a version bump for the next release label Jun 27, 2021
@dr-orlovsky dr-orlovsky added this to the 0.27.0 milestone Jun 27, 2021
@dr-orlovsky dr-orlovsky added this to In progress in PSBT via automation Jun 27, 2021
@dr-orlovsky dr-orlovsky mentioned this pull request Jun 27, 2021
Closed
@dr-orlovsky dr-orlovsky marked this pull request as ready for review June 27, 2021 17:06
sanket1729
sanket1729 previously approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack 15545a5

Kixunil
Kixunil previously approved these changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@dr-orlovsky dr-orlovsky dismissed stale reviews from Kixunil and sanket1729 via 994079b August 1, 2021 19:09
PSBT automation moved this from In progress to Review in progress Aug 1, 2021
@dr-orlovsky
Copy link
Collaborator Author

Had to rebase, so @sanket1729 will acknowledge re-review

sanket1729
sanket1729 approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 994079b

Kixunil
Kixunil approved these changes Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK

@dr-orlovsky dr-orlovsky added this to In review in Derive unification Aug 9, 2021
Derive unification automation moved this from In review to Merge Ready Sep 8, 2021
apoelstra
apoelstra approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 994079b

PSBT automation moved this from Review in progress to Ready for merge Sep 8, 2021
@apoelstra apoelstra merged commit 13a6c3b into rust-bitcoin:master Sep 8, 2021
Derive unification automation moved this from Merge Ready to Done Sep 8, 2021
PSBT automation moved this from Ready for merge to Done Sep 8, 2021
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 15, 2022
Closed
Derive unification automation moved this from Done to Merge Ready Apr 1, 2022
Derive unification automation moved this from Merge Ready to In review Apr 1, 2022
Derive unification automation moved this from In review to Done Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
API break This PR requires a version bump for the next release
Projects
Derive unification
Done
PSBT
Done
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dr-orlovsky @Kixunil @apoelstra @sanket1729