Fixing no_std for Amount sum iterator #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgeisler
approved these changes
Sep 13, 2021
Closed
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
…deciding between conjunctions and multi/multi_a 200991d compiler: improve logic for deciding between thresholds and ands (Andrew Poelstra) bc3b8dc policy: rename Threshold variant to Thresh (Andrew Poelstra) 78db616 consolidate some FIXMEs (Andrew Poelstra) 0666aef error: remove some unused variants (Andrew Poelstra) b2ec4a8 clippy: fix some nits introduced by rust-bitcoin#651 (Andrew Poelstra) Pull request description: The compiler logic when encountering thresholds of pks is currently a bit confused, and therefore chooses multi/multi_a in cases where this is not the most efficient compilation. This PR fixes that, and also brings in a few other cleanup commits that I had laying around. This does **not** fix rust-bitcoin#656, which I didn't know how to approach. ACKs for top commit: sanket1729: ACK 200991d Tree-SHA512: 252a60891cf1c1d1cd3ded88d97122fd1e76bd25807770f4843ae68bd2d854fc617518f26be86dcb57cd7fc369e1a4be81daa42ee1a6d4bc976dbad6dc1150f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest merge of #615 broke the master b/c it didn't run new
no_stdCI. This PR fixes the problem.